New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handled a case that str is not a string #1169

Merged
merged 1 commit into from Aug 13, 2018

Conversation

Projects
None yet
3 participants
@hkmoon
Contributor

hkmoon commented Aug 13, 2018

Added toString() because we faced an issue where str is not a string and replace() cannot be called while testing intermine integration

If you think this place is not a good place to put toString(), feel free to change it.

Handled a case that str is not a string
Added toString() because we faced an issue where str is not a string and replace() cannot be called while testing intermine integration

@rbuels rbuels added this to the 1.15.2 milestone Aug 13, 2018

@rbuels

This comment has been minimized.

Show comment
Hide comment
@rbuels

rbuels Aug 13, 2018

Collaborator

Looks good, thanks!

Collaborator

rbuels commented Aug 13, 2018

Looks good, thanks!

@rbuels rbuels merged commit 752cd4a into GMOD:master Aug 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Aug 14, 2018

Contributor

Note that this PR was merged onto master instead of dev

Contributor

cmdcolin commented Aug 14, 2018

Note that this PR was merged onto master instead of dev

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Aug 14, 2018

Contributor

I say that because probably good to keep in mind that our PR workflow should merge onto dev :)

Contributor

cmdcolin commented Aug 14, 2018

I say that because probably good to keep in mind that our PR workflow should merge onto dev :)

@rbuels

This comment has been minimized.

Show comment
Hide comment
@rbuels

rbuels Aug 14, 2018

Collaborator
Collaborator

rbuels commented Aug 14, 2018

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Aug 14, 2018

Contributor

Ya PR will by default be sent to master, it is kind of annoying

Contributor

cmdcolin commented Aug 14, 2018

Ya PR will by default be sent to master, it is kind of annoying

rbuels added a commit that referenced this pull request Aug 14, 2018

Merge pull request #1169 from hkmoon/master
Handled a case that str is not a string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment