New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add categoryOrder configuration #1208

Merged
merged 5 commits into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@cmdcolin
Contributor

cmdcolin commented Sep 17, 2018

This adds a categoryOrder configuration option to the tracklist. This is just a comma separated list of category names

So, if applied to volvox sample, you can specify

categoryOrder = VCF, Transcripts, Miscellaneous

This will sort these categories to the top. Small amount of code reformatting goes along with this PR but the core is just the track sorting :)

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Sep 17, 2018

Contributor

Addresses #1203

Contributor

cmdcolin commented Sep 17, 2018

Addresses #1203

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Sep 18, 2018

Contributor

Might go ahead and merge this soon :) let me know if there's any feedback

Contributor

cmdcolin commented Sep 18, 2018

Might go ahead and merge this soon :) let me know if there's any feedback

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Sep 18, 2018

Contributor

Might not actually be ready to push, needs some more fanangling with the sort.

Contributor

cmdcolin commented Sep 18, 2018

Might not actually be ready to push, needs some more fanangling with the sort.

@cmdcolin cmdcolin closed this Sep 19, 2018

@wafflebot wafflebot bot removed the in progress label Sep 19, 2018

@cmdcolin cmdcolin reopened this Sep 30, 2018

@wafflebot wafflebot bot added the in progress label Sep 30, 2018

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Sep 30, 2018

Contributor

This PR is now effective at sorting by category by just putting tracks. Now a user for example could specify a categoryOrder config such as this

[trackList]
categoryOrder=VCF,Quantitative / Density,Transcripts,BAM

Note that specifying the "Quantitative / Density" subcategory helps fulfill the goal of making the whole Quantitative group come up. It was a little involved to allow specifying only a higher level "Quantitative" category for this. Potentially this PR could be enhanced to allow specifying just the higher level category but otherwise this is workable

Contributor

cmdcolin commented Sep 30, 2018

This PR is now effective at sorting by category by just putting tracks. Now a user for example could specify a categoryOrder config such as this

[trackList]
categoryOrder=VCF,Quantitative / Density,Transcripts,BAM

Note that specifying the "Quantitative / Density" subcategory helps fulfill the goal of making the whole Quantitative group come up. It was a little involved to allow specifying only a higher level "Quantitative" category for this. Potentially this PR could be enhanced to allow specifying just the higher level category but otherwise this is workable

@rbuels

This comment has been minimized.

Show comment
Hide comment
@rbuels

rbuels Oct 3, 2018

Collaborator

This looks good, just need to add documentation that will be pushed to the website.

Collaborator

rbuels commented Oct 3, 2018

This looks good, just need to add documentation that will be pushed to the website.

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Oct 4, 2018

Contributor

The documentation is added and we have some basic unit tests added for the sorting too :)

Contributor

cmdcolin commented Oct 4, 2018

The documentation is added and we have some basic unit tests added for the sorting too :)

@cmdcolin cmdcolin merged commit 52961a2 into dev Oct 4, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@wafflebot wafflebot bot removed the in progress label Oct 4, 2018

@cmdcolin cmdcolin deleted the tracklist_category_order branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment