New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setup.sh use webpack production build #1223

Merged
merged 3 commits into from Oct 5, 2018

Conversation

Projects
None yet
2 participants
@cmdcolin
Copy link
Contributor

cmdcolin commented Oct 4, 2018

This PR makes running ./setup.sh use a production build. This can be turned off by setting an environment variable

JBROWSE_BUILD_MIN=0 ./setup.sh

But by default you still just run ./setup.sh which is automatically a production build

Notes:

  • The time difference for setup.sh for me with node modules already downloaded is 30 seconds for JBROWSE_BUILD_MIN=0 vs 90 seconds for JBROWSE_BUILD_MIN=1 (with 1 being the new default by this PR)
  • I also disabled UglifyJsPlugin parallel because it was causing hanging under WSL (possible xref jupyterlab/jupyterlab#4276) but removing it didn't modify build times for me

The payload of the initial page load is about 877kb vs 1.8Mb

@cmdcolin cmdcolin force-pushed the setup_min_build branch from 0fedc49 to f6a2fa7 Oct 4, 2018

@cmdcolin cmdcolin merged commit 35316d8 into dev Oct 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Oct 5, 2018

@cmdcolin cmdcolin deleted the setup_min_build branch Oct 5, 2018

@cmdcolin cmdcolin added this to the 1.16.0 milestone Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment