New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid issue where Range can have max less than min #1229

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
2 participants
@cmdcolin
Copy link
Contributor

cmdcolin commented Oct 8, 2018

This is a PR to address #1226 which found a certain bigbed file that was not able to be loaded natively. I found that essentially a "Range" object was created where max less than the min, and then no action was taken in a specific for loop.

I found that I could modify a Range object creation to remove this particular "Math.min" operation to fix this issue. It's not exactly clear what purpose this had but removing it didn't seem to cause any issue on BigBed or BigWig files I tested. There is also no similar Math.min type operation in the dalliance codebase for BigWig from what I could tell

@wafflebot wafflebot bot added the in progress label Oct 8, 2018

@rbuels

This comment has been minimized.

Copy link
Collaborator

rbuels commented Oct 8, 2018

weird. well ok, if it doesn't look like it's breaking anything else.

@rbuels rbuels merged commit 526a65b into dev Oct 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rbuels rbuels added this to the 1.15.5 milestone Oct 8, 2018

@wafflebot wafflebot bot removed the in progress label Oct 8, 2018

@cmdcolin cmdcolin deleted the fix_bigbed_loading branch Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment