New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix electron app accessing remote files #1245

Merged
merged 3 commits into from Oct 29, 2018

Conversation

Projects
None yet
2 participants
@cmdcolin
Copy link
Contributor

cmdcolin commented Oct 29, 2018

This swaps out the regular fetch for node-fetch when using electron. This mitigates the problem of #1234 where the electron app actually has pretty strict CORS and blocks most headers from being accessed by default.

This also just upgrades to electron version 3.0.6 for funsies. It doesn't appear to break anything so might as well stay up to date :)

cmdcolin added some commits Oct 28, 2018

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Oct 29, 2018

Note that the electron-fetch uses the chrome native networking libs so it purports some benefits with proxies and some other stuff, but it is not available in the browser via electronRequire('electron').net so it would probably need some IPC to make work.

@cmdcolin cmdcolin force-pushed the fix_electron_remote_files branch from 4a2a2c0 to 2fcf509 Oct 29, 2018

@rbuels rbuels merged commit 8b60afc into dev Oct 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rbuels rbuels removed the in progress label Oct 29, 2018

@cmdcolin cmdcolin deleted the fix_electron_remote_files branch Nov 1, 2018

@cmdcolin cmdcolin added this to the 1.16.0 milestone Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment