Fix electron app accessing remote files #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Note that the electron-fetch uses the chrome native networking libs so it purports some benefits with proxies and some other stuff, but it is not available in the browser via electronRequire('electron').net so it would probably need some IPC to make work. |
cmdcolin
force-pushed
the
fix_electron_remote_files
branch
from
4a2a2c0
to
2fcf509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This swaps out the regular fetch for node-fetch when using electron. This mitigates the problem of #1234 where the electron app actually has pretty strict CORS and blocks most headers from being accessed by default.
This also just upgrades to electron version 3.0.6 for funsies. It doesn't appear to break anything so might as well stay up to date :)