New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add datasetLinkToParent option #1248

Merged
merged 2 commits into from Nov 8, 2018

Conversation

Projects
None yet
2 participants
@enuggetry
Copy link
Contributor

enuggetry commented Oct 31, 2018

Complements genome bookmark feature (for datasets under the Genome menu).

if defined in config, the selected dataset will load into the parent of an iframe, instead of in the iframe.

e.g.:

        "datasetLinkParent":true,
        "datasets": {
                "wheat": {
                        "name": "Wheat",
                        "url":"http://localhost/a.html",
                },
                "barley": {
                        "name": "Barley",
                        "url":"http://localhost/b.html",
                }
        }
@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Nov 1, 2018

I think this doesn't affect when classicMenu=true is on, would you want to add that to this PR?

@enuggetry

This comment has been minimized.

Copy link
Contributor

enuggetry commented Nov 1, 2018

@cmdcolin cmdcolin force-pushed the bookmark-link-to-parent branch from 6f8d838 to 95e040f Nov 8, 2018

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Nov 8, 2018

I changed the variable name to use datasetLinkToParentIframe and made it work on classicMenu :)

@cmdcolin cmdcolin merged commit e4e84ab into dev Nov 8, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@wafflebot wafflebot bot removed the in progress label Nov 8, 2018

@cmdcolin cmdcolin added this to the 1.16.0 milestone Nov 8, 2018

@cmdcolin cmdcolin deleted the bookmark-link-to-parent branch Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment