New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a div instead of a content-pane for hierarchical track selector #1253

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
3 participants
@cmdcolin
Copy link
Contributor

cmdcolin commented Nov 6, 2018

I found that just swapping out a div for a ContentPane seemed to fix the issue of #1240. Feel free to test. My test setup was just making the modencode example use the hierarchical track selector.

@wafflebot wafflebot bot added the in progress label Nov 6, 2018

@cmdcolin cmdcolin force-pushed the fixup_hierarchical_height branch from d492bbe to ea3e12e Nov 6, 2018

@rbuels

This comment has been minimized.

Copy link
Collaborator

rbuels commented Nov 7, 2018

@nathanhaigh could you try out the modification @cmdcolin made here? does that fix it?

@rbuels

This comment has been minimized.

Copy link
Collaborator

rbuels commented Nov 7, 2018

@nathanhaigh could you try out the modification @cmdcolin made here? does that fix it?

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Nov 9, 2018

I'm fairly sure it does fix the issue...maybe we can merge since that modencode example does reproduce and get fixed

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Nov 9, 2018

Note that some peoples custom code to modify the hierarchical selector to have logos will need updating e.g. wormbase

@cmdcolin cmdcolin merged commit c872acc into dev Nov 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Nov 9, 2018

@nathanhaigh

This comment has been minimized.

Copy link
Contributor

nathanhaigh commented Nov 9, 2018

Sorry...haven't had a chance to test...will try to do so this weekend.

@nathanhaigh

This comment has been minimized.

Copy link
Contributor

nathanhaigh commented Nov 17, 2018

This fixes the track selector space I was seeing once switching to a metadata file. @cmdcolin @rbuels

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Nov 17, 2018

awesome :) good to know

@cmdcolin cmdcolin deleted the fixup_hierarchical_height branch Nov 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment