New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace in flatfile keys and values #1254

Merged
merged 4 commits into from Nov 12, 2018

Conversation

Projects
None yet
1 participant
@cmdcolin
Copy link
Contributor

cmdcolin commented Nov 6, 2018

This performs whitespace trimming on the attribute keys and values in a GFF3. Multivalued comma separated lists of things in the GFF3 attributes also individually get the start and end trimming.

@wafflebot wafflebot bot added the in progress label Nov 6, 2018

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Nov 6, 2018

Ref #1221

@cmdcolin cmdcolin force-pushed the fix_whitespace_hashkeys branch from cdc5d76 to 62bf4f8 Nov 6, 2018

@cmdcolin cmdcolin force-pushed the fix_whitespace_hashkeys branch from 62bf4f8 to e56619c Nov 6, 2018

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Nov 9, 2018

Any opposition to this one? I think it should be fairly straightforward. I made a PR to gff-js that does the same thing

@cmdcolin cmdcolin added this to the 1.16.0 milestone Nov 12, 2018

@cmdcolin cmdcolin merged commit ed66a63 into dev Nov 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Nov 12, 2018

@cmdcolin cmdcolin deleted the fix_whitespace_hashkeys branch Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment