New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent layout on some GFF features #1260

Merged
merged 2 commits into from Nov 15, 2018

Conversation

Projects
None yet
3 participants
@cmdcolin
Copy link
Contributor

cmdcolin commented Nov 12, 2018

This addresses #1244 for GFF files. The crc32 of the line is assigned as the uniqueID in a similar way to the fileOffset that was there already

cmdcolin added some commits Nov 12, 2018

@garrettjstevens

This comment was marked as resolved.

Copy link
Contributor

garrettjstevens commented on 60319f9 Nov 12, 2018

Just out of curiosity, what made you choose to use buffer-crc32 instead of JBrowse/Digest/Crc32?

This comment was marked as resolved.

Copy link
Contributor

cmdcolin replied Nov 12, 2018

I figured that maybe the dedicated module could have a better optimized implementation, hard to say though. I mean if we really wanted performance could use xxhash or something..

This comment was marked as resolved.

Copy link
Collaborator

rbuels replied Nov 12, 2018

using the npm module will also make the code easier to port to jbrowse 2

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Nov 15, 2018

If there are not any issues with this conceptually i'll go ahead and merge...

@cmdcolin cmdcolin merged commit 341e624 into dev Nov 15, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Nov 15, 2018

@cmdcolin cmdcolin added this to the 1.16.0 milestone Nov 15, 2018

@cmdcolin cmdcolin deleted the use_gff_linehash branch Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment