New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ie11 babel #1267

Merged
merged 7 commits into from Nov 23, 2018

Conversation

Projects
None yet
1 participant
@cmdcolin
Copy link
Contributor

cmdcolin commented Nov 22, 2018

By combining

rbuels/http-range-fetcher#1
GMOD/cram-js#7
GMOD/bam-js#11
GMOD/indexedfasta-js#5
GMOD/tabix-js#9
GMOD/tribble-index-js#3
GMOD/bgzf-filehandle#4

We can get IE11 to work

Additional todo might be to display a proper error message if jbrowse is unsupported instead of failing without error

It seems bgzf-filehandle might use promise.reset which doesn't exist in es6-promisify also

ie11

@cmdcolin cmdcolin force-pushed the fix_ie11_babel branch from 76a2e70 to c899380 Nov 22, 2018

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Nov 22, 2018

Also happy thanksgiving gobble gobble

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Nov 22, 2018

🦃

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Nov 23, 2018

I think after applying all the package updates ie11 build works :)

cmdcolin added some commits Nov 23, 2018

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Nov 23, 2018

I suppose if there is no issue I can merge this :)

@cmdcolin cmdcolin merged commit a56d89e into dev Nov 23, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@wafflebot wafflebot bot removed the in progress label Nov 23, 2018

@cmdcolin cmdcolin added this to the 1.16.0 milestone Nov 23, 2018

@cmdcolin cmdcolin deleted the fix_ie11_babel branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment