New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack4 build #1270

Merged
merged 2 commits into from Dec 26, 2018

Conversation

Projects
None yet
2 participants
@cmdcolin
Copy link
Contributor

cmdcolin commented Nov 26, 2018

I found this PR to dojo-webpack-plugin enabled webpack 4 builds to work with jbrowse OpenNTF/dojo-webpack-plugin#185

There are not any urgent reasons to upgrade afaik. Purported speed improvements and better build defaults for dev vs prod builds but its not altogether a big thing for jbrowse codebase

@rbuels

This comment has been minimized.

Copy link
Collaborator

rbuels commented Dec 26, 2018

OpenNTF/dojo-webpack-plugin#185 says the 2.7.7 release fixes it, want to bump it and test when you get a chance?

@cmdcolin cmdcolin force-pushed the webpack4_build branch from 6fb0387 to 2f78a9f Dec 26, 2018

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Dec 26, 2018

Updated that and rebased on dev :)

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Dec 26, 2018

Looks good after testing

@cmdcolin cmdcolin merged commit e86869a into dev Dec 26, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@wafflebot wafflebot bot removed the in progress label Dec 26, 2018

@cmdcolin cmdcolin deleted the webpack4_build branch Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment