New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name generator #1283

Merged
merged 4 commits into from Dec 11, 2018

Conversation

Projects
None yet
1 participant
@cmdcolin
Copy link
Contributor

cmdcolin commented Dec 11, 2018

This modifies the name generator to loop and fill up the operation buffer for a bit while indexing

The main issue was that make_operations($name_record) could return empty so this would cause the indexing to end prematurely

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Dec 11, 2018

Xref #1275

@cmdcolin cmdcolin force-pushed the fix_name_generator branch from e4fe614 to ad59c2a Dec 11, 2018

@cmdcolin cmdcolin force-pushed the fix_name_generator branch from ad59c2a to 8a42c14 Dec 11, 2018

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Dec 11, 2018

I made a failing test case as I said I should. Some people may not have been affected by this because it depends on such things as the number of refseqs that you had and the completion limit, because it depends on the refseqs and their completions overflowing the initial 50000 buffer that is setup before a problem is encountered.

@cmdcolin cmdcolin merged commit dc3c2bc into dev Dec 11, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@wafflebot wafflebot bot removed the in progress label Dec 11, 2018

@cmdcolin cmdcolin deleted the fix_name_generator branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment