New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No content range fixes #1292

Merged
merged 7 commits into from Dec 26, 2018

Conversation

Projects
None yet
2 participants
@cmdcolin
Copy link
Contributor

cmdcolin commented Dec 26, 2018

This adds some changes to bypass http-range-fetcher basically when there are full file requests like for an index file, where in that case the range end is undefined and start is just 0

Addresses #1289

Could also be addressed on the http-range-fetcher side of things but I basically saw it as unnecessary to divide into chunks so it is implemented with plain fetches here (with a small extra lru cache)

Show resolved Hide resolved src/JBrowse/Model/XHRBlob.js Outdated

@rbuels rbuels added this to the 1.16.1 milestone Dec 26, 2018

@rbuels rbuels merged commit d2c3aae into dev Dec 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Dec 26, 2018

@rbuels rbuels deleted the no_content_range_enhance2 branch Dec 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment