New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional fix bounds on XYPlot ruler #1306

Merged
merged 3 commits into from Jan 24, 2019

Conversation

Projects
None yet
1 participant
@cmdcolin
Copy link
Contributor

cmdcolin commented Jan 24, 2019

This adds fixBounds config to XYPlot tracks which can be set to false, "none", "micro", "minor", or "major" (default major, setting to false == 'none')

Applies to both fixLower and fixUpper in https://dojotoolkit.org/reference-guide/1.10/dojox/charting.html

@cmdcolin

This comment has been minimized.

Copy link
Contributor Author

cmdcolin commented Jan 24, 2019

Here is how it looks on volvox microarray bw with min_score set to 884. The max score in this region is 882. So when fixBounds is default major, it rounds down to 880 and then it displays a small peak. When fixBounds is false though it shows through

screenshot-localhost-2019 01 24-18-22-54 2
screenshot-localhost-2019 01 24-18-22-54

@cmdcolin cmdcolin merged commit 83e430c into dev Jan 24, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@wafflebot wafflebot bot removed the in progress label Jan 24, 2019

@cmdcolin cmdcolin deleted the optional_fixbounds branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment