Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Display gene subfeatures even if topLevelFeatures is not set #1340
This PR allows to display gene subfeatures in HTMLFeatures (and NeatHTMLFeature) tracks, even if topLevelFeatures is not set "properly".
This is typically for gff files containing gene > mRNA > exon/CDS data.
Setting topLevelFeatures works nice, but :
The code is inspired/adapted from #996
I am open to other opinions, but to me this changes a default behavior that jbrowse has had for basically forever, and even though it is basically better this way, I guess I would say this alternative behavior needs to be dependent on a configurable global variable that an instance admin can set (e.g. browser.config.inferHTMLSubfeatures or similar)
nathandunn left a comment
I think this is correct.
I think that @cmdcolin point is valid, however, I think if this is the default/ desired behavior, maybe we leave it in as-is. I ended up working around this by automatically specifying it, but I agree that this is the behavior a user would expect 98% of the time. We could add a global to ignore the other 2%