Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeatHTMLFeatures: fix error when too many features to display #1368

Merged
merged 1 commit into from May 30, 2019

Conversation

Projects
None yet
3 participants
@abretaud
Copy link
Contributor

commented May 23, 2019

2 small fixes to avoid error messages when there are too many features to display them all (maximum height reached).
In this case, renderFeature returns null, and we need to check this bfore trying to insertIntrons or appendChild

@abretaud

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

ah network problems on travis?

@garrettjstevens

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

Looks like there were network problems with the travis job, but I re-ran it and it looks fine now.

@cmdcolin cmdcolin merged commit 1fed59d into GMOD:dev May 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cmdcolin

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

Thanks for this, I trust that you have the right idea here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.