Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use object-hash package from npm instead of objectFingerprint #1412

Merged
merged 1 commit into from Aug 2, 2019
Merged

Conversation

@cmdcolin
Copy link
Contributor

cmdcolin commented Aug 2, 2019

I can see from some metrics that the objectFingerprint in @scottcain's code is taking a long time. I thought maybe an off-the-shelf version from NPM could speed up

I tested with electron remotely loading his codebase and it was way faster indeed

@cmdcolin cmdcolin merged commit ee51a8c into dev Aug 2, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@cmdcolin cmdcolin deleted the object_hash branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.