Fix usage of TS vs ts #1493
Merged
Fix usage of TS vs ts #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh man. Yeah I guess that's about as good as can be gotten. Attributes are case-sensitive in JB2, so we should be OK there I hope. |
|
Yep. It might be that bam-js should adopt a similar thing to cram-js records with the tags() method, but it would no longer become a lazy feature if it does that (there might be some middleground though, not sure) |
|
The contents of this PR were changed so that now it doesn't use case sensititve, it just uses the "useXS" and applies to TS tag while the user interface clarifies that useTS applies to the lower case
|
|
Fix on dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a special case handling to fix the bug in #1484 but it is slightly awkward, not sure if there is a better way to do this.