New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sequence cache #855

Merged
merged 12 commits into from Apr 17, 2018

Conversation

Projects
None yet
3 participants
@cmdcolin
Contributor

cmdcolin commented Feb 17, 2017

This adds an LRUCache for sequence track. First noticed here #641

This does have some speedups if you are making many requests to the sequence store, and you can see that it is in effect as the network console stops making repeated requests for the same file

It handles the 404 case well and has the bar that says "No sequence available" just as before

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Feb 17, 2017

There was actually an interesting case where NCList tracks did the repeated requests too, but it would only manifest with a larger NCList track (small ones only have a trackData.json file, larger ones have a series of lf-{Chunk}.json files, and the lf-{Chunk}.json files would receive repeated requests)

So that gets a LRUCache now too

@rbuels rbuels added this to the 1.12.4 milestone Jan 24, 2018

@rbuels rbuels self-assigned this Jan 24, 2018

@wafflebot wafflebot bot added the in progress label Jan 27, 2018

@rbuels rbuels modified the milestones: 1.12.4, 1.13.0 Feb 2, 2018

@rbuels rbuels assigned cmdcolin and rbuels and unassigned rbuels and cmdcolin Feb 7, 2018

@nathandunn nathandunn changed the base branch from master to dev Feb 7, 2018

@rbuels rbuels modified the milestones: 1.13.0, 1.13.1 Mar 14, 2018

@rbuels rbuels modified the milestones: 1.13.1, 1.14.0 Mar 23, 2018

@rbuels rbuels removed this from the 1.14.0 milestone Apr 9, 2018

@rbuels rbuels added this to the 1.14.1 milestone Apr 9, 2018

@rbuels rbuels modified the milestones: 1.14.1, 1.14.0 Apr 17, 2018

@rbuels rbuels merged commit 946ea2e into dev Apr 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@cmdcolin cmdcolin deleted the add_chunk_caching branch Apr 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment