New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removeCollapsedClick and removeCollapsedMouseover options #870

Merged
merged 6 commits into from Mar 8, 2018

Conversation

Projects
None yet
5 participants
@cmdcolin
Contributor

cmdcolin commented Mar 22, 2017

This is a PR to address #544

This PR adds two config options

removeCollapsedClick - is false by default, but can be made true to address @rdhayes concern
removeCollapsedMouseover - remains true by default, but it can be made false to allow mouseovers to where the collapsed features are non-overlapping

Therefore track behavior is by default the same as previous jbrowse versions, but with these added config enhancements.

This also adds a sample demo track to volvox data with "segmentation" data

@rdhayes

This comment has been minimized.

Contributor

rdhayes commented May 1, 2017

Hi, I'll test this out this week, but that should clean up collapsed display in my view. To go one step further, I'd like to add a new track-level mouseover when in "collapsed" state that triggers a switch to "normal" display. Do you have any advice on which dojo Milestone to track in this case?

"/jbrowse/v1/c/tracks/show" or "/jbrowse/v1/n/tracks/redraw"? or perhaps both?

Thanks!

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented May 2, 2017

I'd like to add a new track-level mouseover when in "collapsed" state that triggers a switch to "normal" display

That is kind of a weird use case but could grant it. I guess I'd probably not want to switch between "collapsed and normal" really suddenly but it could work
In any case the jbrowse events don't really track mouseovers if that's what you are asking, but you can use the jbrowse events to dynamically edit the config in-place by using something like browser.publish('/jbrowse/v1/v/tracks/replace', [newconfig]);

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Jan 29, 2018

@cmdcolin What do you think about renaming these to disabledCollapsed* instead removeCollapsed*. A new user would think that "remove" would imply that you remove features when you collapse them or something.

I like that there is more test data now, that's a good addition.

I brought this branch up to date with the latest master, so that it gets the selenium tests running in travis.
@cmdcolin @rdhayes Would one of you be willing to add a selenium test for this?

@wafflebot wafflebot bot added the in progress label Jan 29, 2018

@rbuels rbuels added this to the 1.12.4 milestone Jan 29, 2018

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Jan 29, 2018

Sounds good to me. I renamed them enableCollapsedMouseover and disableCollapsedClick to make it easier (e.g. if you want either of these settings, you set them to true, rather than wrapping around a double negative of setting disableCollapsedMouseover to false)

If I can get selenium running locally I can look into adding a test for it

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Jan 29, 2018

pip install nose selenium
brew install geckodriver chromedriver
./jb_run.js -p 8080 &
SELENIUM_BROWSER=firefox JBROWSE_URL='http://localhost:8080/index.html' nosetests
SELENIUM_BROWSER=chrome JBROWSE_URL='http://localhost:8080/index.html' nosetests

@rbuels rbuels modified the milestones: 1.12.4, 1.13.0 Feb 2, 2018

@nathandunn nathandunn changed the base branch from master to dev Feb 7, 2018

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Feb 16, 2018

I added a small selenium test that ensures that I get a mouseover when the track is collapsed based on the volvox sample data now :)

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Feb 27, 2018

could you add a release-notes blurb about this?

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Feb 28, 2018

Added the blurb :)

@rbuels rbuels merged commit ce1ac92 into dev Mar 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Mar 8, 2018

@cmdcolin cmdcolin deleted the collapsed_mouseover branch Mar 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment