New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for when description is modified #885

Merged
merged 4 commits into from Feb 26, 2018

Conversation

Projects
None yet
4 participants
@cmdcolin
Contributor

cmdcolin commented Apr 28, 2017

This is a workaround that when style->description is modified, it is also changed in the View details box, but in the case that you still want to display Note in the popup, you can set a flag showNoteInAttributes on your track.

It is sort of a crazy situation where this requires a special flag, as it might make sense to automatically figure this out, but this is sort of a special case workaround that users who are modifying style->description can be made aware of (style->description modifies the displayed blue description in the genome browser display and in the popup so sometimes it is worthwhile to have the displayed one be different than the popups)

Ref #555 and http://gmod.827538.n3.nabble.com/Display-GFF-quot-Note-quot-attribute-but-not-in-the-quot-Description-quot-field-td4057463.html

@loraine-gueguen

This comment has been minimized.

Contributor

loraine-gueguen commented Jul 28, 2017

Thanks @cmdcolin !
I have tried the patch: it works well for me. I can now display Note in the Attributes section while displaying Product in the Description field (in Primary data).
With in trackList.json:
"style" : { "description" : "product, note, description" }, "showNoteInAttributes" : true,
Will this patch be integrated in the next JBrowse release ?

@nathandunn

This comment has been minimized.

Contributor

nathandunn commented Jul 28, 2017

I think it would be fine to put into master. It will then get into the next release whenever that happens.

@wafflebot wafflebot bot added the in progress label Feb 1, 2018

@nathandunn nathandunn changed the base branch from master to dev Feb 7, 2018

@loraine-gueguen

This comment has been minimized.

Contributor

loraine-gueguen commented Feb 26, 2018

Trying to help to close this PR: I have seen that the failing selenium jasmine test has been updated 10 days ago, and the Travis build now passed (tried on my fork). Just rerun the build and it should be ok. Unless there is some more dev to do on this PR ?

@rbuels rbuels added this to the 1.12.5 milestone Feb 26, 2018

@rbuels rbuels merged commit d281ba1 into dev Feb 26, 2018

@wafflebot wafflebot bot removed the in progress label Feb 26, 2018

@cmdcolin cmdcolin deleted the show_note_in_additional branch Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment