New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change "Length on ref" to "Seq length on ref" #939

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@colindaven
Contributor

colindaven commented Nov 14, 2017

I wanted to change "Length on ref" to "Seq length on ref" as the former is most frequently used with the "Seq length" tag.

"Seq length" and "Seq length on ref" would then be alphabetically sorted to the same region in the bam lazyfeature dialog box in the UI (I hope). This has NOT been tested (no test environment here, hopefully this is just a minor commit).

change "Length on ref" to "Seq length on ref"
I wanted to change "Length on ref" to "Seq length on ref" as the former is most frequently used with the "Seq length" tag.

"Seq length" and "Seq length on ref" would then be alphabetically sorted to the same region in the bam lazyfeature dialog box in the UI (I hope). This has NOT been tested
@rbuels

This comment has been minimized.

Collaborator

rbuels commented Jan 29, 2018

@colindaven So if I understand correctly, what you're going for here is for the "Length on ref" field in the default detail dialog to appear sorted next to the "Seq length" field. Primarily for better readability when displayed?

@rbuels rbuels self-requested a review Jan 29, 2018

@rbuels rbuels self-assigned this Jan 29, 2018

@rbuels rbuels added this to the 1.12.4 milestone Jan 29, 2018

@colindaven

This comment has been minimized.

Contributor

colindaven commented Jan 31, 2018

Yes, I just want to change the sort order for readability. Great to see you're back involved in the JBrowse project again (at least to my knowledge, maybe you were still involved all along ...).

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Jan 31, 2018

Ah, this is a good idea, but it needs to be done a different way so that we don't change the attribute names that come out of the BAM store, because I'm sure at this point that lots of people's custom code relies on it. See 804b8fe for what I did instead.

@rbuels rbuels closed this Jan 31, 2018

@colindaven

This comment has been minimized.

Contributor

colindaven commented Feb 1, 2018

Ok, thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment