New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow "key" in a tracks metadata to be used if the track configuratio… #958

Merged
merged 3 commits into from Jan 24, 2018

Conversation

Projects
None yet
1 participant
@rbuels
Collaborator

rbuels commented Jan 23, 2018

…n does not have "key" set

fixes #957

@wafflebot wafflebot bot added the in progress label Jan 23, 2018

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Jan 23, 2018

@enuggetry can I get a code review on this, and merge if it looks reasonable?

Also, how can we re-run that travis build that timed out?

@rbuels rbuels closed this Jan 23, 2018

@rbuels rbuels reopened this Jan 23, 2018

@wafflebot wafflebot bot added in progress and removed in progress labels Jan 23, 2018

rbuels added some commits Jan 23, 2018

@rbuels rbuels added this to the 1.12.4 milestone Jan 24, 2018

@rbuels rbuels merged commit 5dd3fe3 into master Jan 24, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@wafflebot wafflebot bot removed the in progress label Jan 24, 2018

@rbuels rbuels deleted the issue/957_keys_from_track_metadata branch Feb 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment