New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gave travis the ability to create github releases and upload built zip files to them when tagged #979

Merged
merged 36 commits into from Feb 7, 2018

Conversation

Projects
None yet
3 participants
@rbuels
Collaborator

rbuels commented Feb 7, 2018

Also runs selenium tests against the minified JBrowse release, instead of the source code, so that we test the (rather untrustworthy) minification.

Fixes #822

rbuels added some commits Feb 3, 2018

@rbuels rbuels added this to the 1.12.4 milestone Feb 7, 2018

@rbuels rbuels requested review from cmdcolin and enuggetry Feb 7, 2018

@wafflebot wafflebot bot added the in progress label Feb 7, 2018

@rbuels rbuels requested a review from nathandunn Feb 7, 2018

@nathandunn

I'm not seeing anything too weird. I feel like there should be a better way to install geckodriver, but I don't see one. Once the travis stuff passes, I'll test it locally.

@nathandunn

This comment has been minimized.

Contributor

nathandunn commented Feb 7, 2018

@rbuels Getting this in the travis PR build:

0.00s$ if [[ ! -d ~/python ]]; then virtualenv ~/python; fi
0.00s$ source ~/python/bin/activate
/home/travis/.travis/job_stages: line 57: /home/travis/python/bin/activate: No such file or directory
The command "source ~/python/bin/activate" failed and exited with 1 during .
@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Feb 7, 2018

I think this is great. Id kind of like the jbrowse desktop electron app to be up to date too. If people agree it should stay maintained then it can probably be built and deployed too

@nathandunn nathandunn removed their assignment Feb 7, 2018

look for virtualenv activate script to determine whether virtualenv n…
…eeds to be run, instead of just the python directory
@rbuels

This comment has been minimized.

Collaborator

rbuels commented Feb 7, 2018

@nathandunn ok i just committed a change to hopefully fix that virtualenv detection bug

@cmdcolin we need to talk about the electron app, I don't have a good idea of how it works. do you have time for a phone call today to talk about it?

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Feb 7, 2018

Sure. I should be available, maybe 5 eastern. Can be on Gchat or skype

@rbuels rbuels changed the base branch from master to dev Feb 7, 2018

@rbuels rbuels merged commit 797f6b3 into dev Feb 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Feb 7, 2018

@rbuels rbuels deleted the continuous_deployment branch Feb 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment