Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Really nice component! #4

Open
johnnyd opened this Issue · 1 comment

2 participants

@johnnyd

Just want to say this is an awesome little component, I've been looking around for awhile now and have only found 1 component that is on par with your implementation and that is KKGridView, though to get it to archive is (static library madness,at least for me) impossible, so suffice it to say, that when I found yours and tested it out and saw how good it worked I was happy and relieved all at once! :) There is one thing I would suggest changing and that is the deleteButton in GMGridViewCell+Extended.h as it may clash with an already existing deleteButton property name in a custom GMGridViewCell subclass. Incidentally, this happened to me and left me scratching my head for a half an hour wondering why my deleteButton wasn't showing up. Maybe some naming convention would help, or at least a warning in the documentation to not define "reserved" property names in GridViewCell subclasses, i.e. deleteButton :). Keep up the good work and when I get some time I will most definitely try to contribute something! :)

@gmoledina
Owner

Thanks for the nice comment johnnyd.

I didn't think there would be a need to subclass the cell itself; but yeah I'll take some time to document as you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.