New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applescript support for getting/setting ANSI colors #10

Merged
merged 7 commits into from Jun 30, 2011

Conversation

Projects
None yet
2 participants
@pjaspers

pjaspers commented Jun 26, 2011

As discussed here, I've updated the code to match the coding guidelines and used the dev branch.

Cheers

{
if (color == nil) return;
[self setColorTable:0 color:color];

This comment has been minimized.

@gnachman

gnachman Jun 27, 2011

Owner

Incorrect indentation for these lines (should be indented 4 spaces)

- (void)setAnsiBlackColor:(NSColor*) color
{
if (color == nil) return;

This comment has been minimized.

@gnachman

gnachman Jun 27, 2011

Owner

Needs braces; so this would be better:
if (color) {
[self setColorTable:0 color:color];
}

This comment has been minimized.

@pjaspers

pjaspers Jun 30, 2011

I'll correct it to your style, but I don't agree with it :)

I like to keep the happy path on the left, and this style just nests it, but to each his own.

@gnachman

This comment has been minimized.

Owner

gnachman commented Jun 27, 2011

Thanks for making the changes. Just address the one line comment I added and it can be pulled.
-G

@pjaspers

This comment has been minimized.

pjaspers commented Jun 30, 2011

Changed to be in style with the coding guidelines.

gnachman added a commit that referenced this pull request Jun 30, 2011

Merge pull request #10 from pjaspers/dev
Applescript support for getting/setting ANSI colors

@gnachman gnachman merged commit d8f8e47 into gnachman:dev Jun 30, 2011

@gnachman

This comment has been minimized.

Owner

gnachman commented Jun 30, 2011

Thanks a lot!

@pjaspers

This comment has been minimized.

pjaspers commented Jun 16, 2014

@gnachman Did this ever land in master?

Edit: I don't think it did. Is this something that could land in master? If so do I just issue a new pull request?

@gnachman

This comment has been minimized.

Owner

gnachman commented Jun 18, 2014

Yow, forgot about the dev branch :(
I've brought this over.

@pjaspers

This comment has been minimized.

pjaspers commented Jun 19, 2014

Cool, thanks!

gnachman pushed a commit that referenced this pull request Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment