Applescript support for getting/setting ANSI colors #10
Conversation
Session/PTYSession.m
Outdated
| { | ||
| if (color == nil) return; | ||
|
|
||
| [self setColorTable:0 color:color]; |
gnachman
Jun 27, 2011
Owner
Incorrect indentation for these lines (should be indented 4 spaces)
Incorrect indentation for these lines (should be indented 4 spaces)
Session/PTYSession.m
Outdated
|
|
||
| - (void)setAnsiBlackColor:(NSColor*) color | ||
| { | ||
| if (color == nil) return; |
gnachman
Jun 27, 2011
Owner
Needs braces; so this would be better:
if (color) {
[self setColorTable:0 color:color];
}
Needs braces; so this would be better:
if (color) {
[self setColorTable:0 color:color];
}
pjaspers
Jun 30, 2011
Author
I'll correct it to your style, but I don't agree with it :)
I like to keep the happy path on the left, and this style just nests it, but to each his own.
I'll correct it to your style, but I don't agree with it :)
I like to keep the happy path on the left, and this style just nests it, but to each his own.
|
Thanks for making the changes. Just address the one line comment I added and it can be pulled. |
|
Changed to be in style with the coding guidelines. |
gnachman
added a commit
that referenced
this pull request
Jun 30, 2011
Applescript support for getting/setting ANSI colors
|
Thanks a lot! |
|
@gnachman Did this ever land in master? Edit: I don't think it did. Is this something that could land in |
|
Yow, forgot about the dev branch :( |
|
Cool, thanks! |
alex-ross
pushed a commit
to alex-ross/iTerm2
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
As discussed here, I've updated the code to match the coding guidelines and used the
devbranch.Cheers