Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applescript support for getting/setting ANSI colors #10

Merged
merged 7 commits into from Jun 30, 2011

Conversation

pjaspers
Copy link

As discussed here, I've updated the code to match the coding guidelines and used the dev branch.

Cheers

{
if (color == nil) return;

[self setColorTable:0 color:color];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation for these lines (should be indented 4 spaces)

@gnachman
Copy link
Owner

Thanks for making the changes. Just address the one line comment I added and it can be pulled.
-G

@pjaspers
Copy link
Author

Changed to be in style with the coding guidelines.

gnachman added a commit that referenced this pull request Jun 30, 2011
Applescript support for getting/setting ANSI colors
@gnachman gnachman merged commit d8f8e47 into gnachman:dev Jun 30, 2011
@gnachman
Copy link
Owner

Thanks a lot!

@pjaspers
Copy link
Author

@gnachman Did this ever land in master?

Edit: I don't think it did. Is this something that could land in master? If so do I just issue a new pull request?

@gnachman
Copy link
Owner

Yow, forgot about the dev branch :(
I've brought this over.

@pjaspers
Copy link
Author

Cool, thanks!

gnachman pushed a commit that referenced this pull request Jan 6, 2016
alex-ross pushed a commit to alex-ross/iTerm2 that referenced this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants