Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility of tab bar #122

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
2 participants
@dusek
Copy link
Contributor

commented Mar 31, 2013

More information in commit messages.

I will also try to submit a pull request to dorianj/PSMTabBarControl,
as I now discovered that is the source :-)

dusek added some commits Mar 31, 2013

Fix accessibility of PSMTabBarControl
* it's now an AXTabGroup - thanks to AXTabs the position of the tab
  and total tab count are announced
* AXChildren shows only visible tabs, and all buttons (like overflow)
* AXValue + AXValueChanged notification enable announcing new tab name
  when switching between them with Cmd-Shift-[] (for unknown reason
  does not do that quite yet)
Fix numberOfVisibleTabs
This returned one more in case an overflow menu is shown.
Fix accessibility of PSMTabBarCell
* being AXRadioButton, VoiceOver indicates there is exclusive
  choice (i.e. only one button can be selected at a time, just like a
  radio button), also in conjunction with AXTabs of its parent reports
  proper position
* implemented visual bounds - yields proper VoiceOver cursor bounds
  and also enables touch exploration
* implemented AXTitle - so that the proper name is read when
  navigating the buttons
* implemented AXValue - so that the selected tab can announce itself
  as such (AXFocused is for elements having keyboard focus, i.e. being
  first responder, which is something quite different than being
  selected from a list of other options)
@dusek

This comment has been minimized.

Copy link
Contributor Author

commented Mar 31, 2013

For the record, just submitted as dorianj/PSMTabBarControl#32

@dusek

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2013

For the record again, the pull request dorianj/PSMTabBarControl#32 has been pulled

@gnachman

This comment has been minimized.

Copy link
Owner

commented Apr 16, 2013

Merged. Thanks!

@gnachman gnachman closed this Apr 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.