Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to .NET Standard #1

Merged
merged 3 commits into from Dec 15, 2018

Conversation

@MarcosCobena
Copy link
Contributor

commented Dec 13, 2018

Thanks for your library :-)

@MarcosCobena

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2018

Hi again,

Yesterday I run out of time and couldn't run tests on my macOS —we could move such to xUnit in a future too.

Today I confirm everything keeps working after moving to .NET Standard: all tests keep green and the solution builds just fine —did this on Windows with VS 2017.

The project's ready for building in Release and uploading a new version to NuGet, would it be possible you make such please? We'd like to consume such in

https://github.com/Microsoft/TailwindTraders-Mobile

which will for sure give some visilibity of the work you're doing :-)

Thanks again,

—Marcos

@MarcosCobena MarcosCobena changed the title Updated to .NET Standard 2.0 Updated to .NET Standard Dec 14, 2018

@gnaeus gnaeus merged commit a601edc into gnaeus:master Dec 15, 2018

@gnaeus

This comment has been minimized.

Copy link
Owner

commented Dec 15, 2018

Thanks! I will publish new version tomorrow.

@MarcosCobena

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2018

Ping, please :-)

@gnaeus

This comment has been minimized.

Copy link
Owner

commented Jan 15, 2019

Sorry for the long wait. I've been ill all this month =(
But now I have published a new version 0.1.5 with .NET Standard 2.0 support.

@MarcosCobena

This comment has been minimized.

Copy link
Contributor Author

commented Jan 15, 2019

No problem man, I hope you find better now.

Thanks for publishing!

Take care,

—Marcos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.