Skip to content

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also .
Commits on Feb 07, 2012
@rsc rsc test: disable bug408
Fixes issue 2902.

TBR=golang-dev
CC=golang-dev
http://codereview.appspot.com/5641047
41038a2
@rsc rsc 5l, 6l, 8l: implement -X flag
R=golang-dev, iant
CC=golang-dev
http://codereview.appspot.com/5643050
f9a8a55
@griesemer griesemer go/printer, gofmt: don't print incorrect programs
Be careful when printing line comments with incorrect
position information. Maintain additional state
impliedSemi: when set, a comment containing a newline
would imply a semicolon and thus placement must be
delayed.

Precompute state information pertaining to the next
comment for faster checks (the printer is marginally
faster now despite additional checks for each comment).

No effect on existing src, misc sources.

Fixes issue 1505.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5598054
00fe0d3
@robpike robpike bug408: delete
It's disabled and unreproducible.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5642053
40ee18f
Commits on Feb 08, 2012
@robpike robpike io/ioutil: document EOF behavior in ReadFile and ReadAll
Fixes issue 2862.

R=golang-dev, n13m3y3r, iant
CC=golang-dev
http://codereview.appspot.com/5646048
b9ced0a
@nigeltao nigeltao image: delete the image.Repeated type. 6c271dd
@robpike robpike encoding/hex: canonicalize error type names
Also simplify the tests.

Fixes issue 2849.

R=golang-dev, bradfitz, r
CC=golang-dev
http://codereview.appspot.com/5643045
ffe3c91
@bradfitz bradfitz net/http/httputil: preserve query params in reverse proxy
Fixes issue 2853

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5642056
642cdf3
@robpike robpike bufio: drop error return for NewReaderSize and NewWriterSize
It complicates the interface unnecessarily.
Document this in go1.html.
Also update the go/doc Makefile.

Fixes issue 2836.

R=golang-dev, gri, bradfitz
CC=golang-dev
http://codereview.appspot.com/5642054
16a5856
@bradfitz bradfitz cmd/api: compare multiple contexts
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5626045
347c4e7
@robpike robpike encoding/binary: hide TotalSize
The function has a bizarre signature: it was the only public function there
that exposed the reflect package. Also, its definition is peculiar and hard to
explain. It doesn't merit being exported.

This is an API change but really, it should never have been exported and
it's certain very few programs will depend on it: it's too weird.

Fixes issue 2846.

R=golang-dev, gri, bradfitz
CC=golang-dev
http://codereview.appspot.com/5639054
4725663
@bradfitz bradfitz net/http: don't ignore some errors in tests
to help debug Issue 2651

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5644049
73707a4
@robpike robpike encoding/csv: document ReadAll behavior at EOF
Fixes issue 2847.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5641050
a5a6a4e
@adg adg archive/zip: tweak API and docs.
Fixes issue 2835.

R=golang-dev, n13m3y3r, r, bradfitz
CC=golang-dev
http://codereview.appspot.com/5645051
c4de9a9
@adg adg weekly.2012-02-07
R=golang-dev, dsymonds, r
CC=golang-dev
http://codereview.appspot.com/5615056
5690c7e
@adg adg tag weekly.2012-02-07
R=golang-dev, nigeltao
CC=golang-dev
http://codereview.appspot.com/5645052
32bdde4
@niemeyer niemeyer encoding/xml: add support for the omitempty flag
This also changes the behavior of attribute marshalling so
that strings and byte slices are marshalled even if empty.
The omitempty flag may be used to obtain the previous behavior.

Fixes issue 2899.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5645050
2519144
@robpike robpike 5l: attempt to fix arm build
TBR=rsc

R=golang-dev
CC=golang-dev
http://codereview.appspot.com/5647049
ee86efb
@robpike robpike runtime/cgo: silence warning on windows
It appears to want a * on an indirect function call (assembly language)

TBR=rsc

R=golang-dev
CC=golang-dev
http://codereview.appspot.com/5643054
9f34c6f
@rsc rsc fmt: diagnose invalid verb applied to pointer
Fixes issue 2851.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5644048
16de06c
@rsc rsc strconv: handle very large inputs
Fixes issue 2642.

R=remyoudompheng, r, r
CC=golang-dev
http://codereview.appspot.com/5639052
1f40aba
@rsc rsc time: clean up MarshalJSON, add RFC3339 method
encoding/xml: handle time.Time as recognized type

The long term plan is to define an interface that time.Time
can implement and that encoding/xml can call, but we are
not going to try to define that interface before Go 1.
Instead, special-case time.Time in package xml, because
it is such a fundamental type, as a stop-gap.
The eventual methods will behave this way.

Fixes issue 2793.

R=golang-dev, r, r, n13m3y3r
CC=golang-dev
http://codereview.appspot.com/5634051
ae1873e
@rsc rsc regexp: allow substitutions in Replace, ReplaceString
Add Expand, ExpandString for access to the substitution functionality.

Fixes issue 2736.

R=r, bradfitz, r, rogpeppe, n13m3y3r
CC=golang-dev
http://codereview.appspot.com/5638046
a571804
@bradfitz bradfitz A+C: add Andrew Pritchard (Individual CLA)
R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5646049
f8da28c
@rsc rsc cmd/dist: respect $CC, as quietgcc.bash used to
R=golang-dev, r, iant
CC=golang-dev
http://codereview.appspot.com/5641051
cc7040a
@bradfitz bradfitz cmd/go: connect os.Stdin for go run
Fixes issue 2875

R=golang-dev, r, rsc
CC=golang-dev
http://codereview.appspot.com/5641052
e42f1d5
@awpr awpr database/sql: treat pointers as nullable types like encoding/json
- convert from nil pointers to the nil interface{}
- dereference non-nil pointers
- convert from nil interface{}s to nil pointers
- allocate pointers for non-nil interface{}s
- tests for all of the above

R=golang-dev, bradfitz, rsc, rogpeppe
CC=golang-dev
http://codereview.appspot.com/5630052

Committer: Brad Fitzpatrick <bradfitz@golang.org>
6d25945