Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug fix and potential feature addition #5

Merged
merged 1 commit into from Mar 18, 2013

Conversation

Projects
None yet
2 participants
Contributor

bcooksey commented Feb 22, 2013

The first commit addresses a bug with the abort functionality; check the commit for details.

The second commit is a first attempt at adding a means to empty out the queue. The implementation isn't great, but it works.

@bcooksey bcooksey Fix bug in abort functionality. We stored the deferred object instead…
… of the complete XHR object, so attempting an xhr.abort() caused a fatal
e826edb
Owner

gnarf commented Mar 6, 2013

Thanks for the submission, I'd love to merge the first commit, but want time to think on the second, can you branch em out?

Contributor

bcooksey commented Mar 18, 2013

Broke out the abort fix to stand alone. give me a sec on the queue, looks like that branch contained both commits, doh!

Contributor

bcooksey commented Mar 18, 2013

Should be good now

@gnarf gnarf added a commit that referenced this pull request Mar 18, 2013

@gnarf gnarf Merge pull request #5 from bcooksey/master
Fixes bug with abort functionality
3acbedc

@gnarf gnarf merged commit 3acbedc into gnarf:master Mar 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment