Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Resolve Shop model from config in AppUninstalledJob #128

Closed
awebartisan opened this issue Oct 16, 2018 · 1 comment · Fixed by #129
Closed

Resolve Shop model from config in AppUninstalledJob #128

awebartisan opened this issue Oct 16, 2018 · 1 comment · Fixed by #129

Comments

@awebartisan
Copy link
Contributor

Currently, in AppUninstalledJob.php, base model of package (Shop) is directly being used to find the shop.

use OhMyBrew\ShopifyApp\Models\Shop;

Kindly resolve it using the shopify-app.php inside config as we can override it in most of the cases.

Problem faced: Events on the extended Shop model are not fired, for example Shop Delete event.
@gnikyt
Copy link
Owner

gnikyt commented Oct 16, 2018

Yup overlooked this one, I'll update it to use config.

@tuimz tuimz mentioned this issue Oct 17, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get shop model from config
2 participants
@gnikyt @awebartisan