Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature/split contract #58
Could you help review this PR.
There's several things I do here:
In the future I plan to break it more. But this is the first round. I did it because I wanted in another project to use the contract
Let me know your thoughts please.
josojo left a comment
like the new structure. It also enhances readability etc.
-> could you explain to me the inheritance of constructor? I mentioned it in the comments
-> I will review later the migration scripts
The migration scripts is OK, if you want to read them is fine, but I'm not too worried about them, because for this project we still use truffle 4.
I just provided an alternative truffle 5 migration files for others to use (especially for local development). I use it in the dx-daostack project for example.
I'm more interested in the smart contract changes, cuase I don't want to break the audit :)
I'll review now the tests.
THANKS FOR YOUR COMMENTS!