New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auctioneer powers to update the oracle and master contract #70

merged 1 commit into from Jan 10, 2019


None yet
3 participants
Copy link

anxolin commented Dec 28, 2018

This PR is for allowing any user to upgrade the master contract or the oracle.

Note that they will only be able to upgrade if the auctioneer decided to change the contract. Also there's a time lock, so the users will have to wait for the count down.

During this waiting time the auctioneer also can decide to cancel the update (set 0x0), or set different address.

This simplifies the process, especially if the contract is handled by a DAO, since it would require two votes to do the change.

@anxolin anxolin requested review from josojo and dteiml Dec 28, 2018


josojo approved these changes Jan 2, 2019

Copy link

josojo left a comment

Yes, this is still safe


dteiml approved these changes Jan 4, 2019

@anxolin anxolin merged commit 48b2a47 into release/2.0 Jan 10, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@anxolin anxolin deleted the feature/upgrade-without-auctioneers-powers branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment