New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make price function from price oracle read only #76

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
2 participants
@anxolin
Copy link
Contributor

anxolin commented Jan 11, 2019

Hey!

This is my current proposal for making the price feed read only.

I just don't emit the event any more, and added the view modifier.

I also expose the validity using the getUsdEthPricePeek (but I removed the event).

Lastly, I renamed the method to use camelCase convention, but I left also the old method for the time being while we adapt the projects. I'm happy to remove it for good in this PR too, the find and replace can be done easily in all the project :)

@anxolin anxolin requested review from josojo and W3stside Jan 11, 2019

@josojo

josojo approved these changes Jan 12, 2019

Copy link
Contributor

josojo left a comment

PR is safe

@anxolin anxolin merged commit 29a692e into release/2.0 Jan 14, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@anxolin anxolin deleted the feature/read-only-price-feed branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment