This repository has been archived by the owner on Apr 27, 2022. It is now read-only.
Allow specifying origin parameter for withdrawals #993
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
--origin
flag (the name was chosen to be analogous to the existing--origin
flags in both thedump
andwithdrawService
tasks).This flag allows the caller of
hardhat withdraw
to specify the solver address to use for executing the withdrawal transaction from the settlement contract. Additionally, this PR also makes it possible to call thewithdraw
task for an--origin
for which you do not have a private key. This is important to be able to build withdrawal transactions that can be sent by a Multisig solver for example.Test Plan
Run the
withdraw
task for a short list of tokens so it completes quickly: