Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project properties Tools Paths does not support eclipse variables #125

Closed
ghost opened this issue Jul 8, 2016 · 3 comments

Comments

Projects
None yet
1 participant
@ghost
Copy link

commented Jul 8, 2016

The toolchain path can be set globally, or for the workspace, or for a single project.
The global and workspace settings (Preferences > C/C++ > Build > Global Tools Paths and Workspace Tools Paths) can accept eclipse variables*; eg ${eclipse_home}bin.

This is not the case for the project settings (Project properties > C/C++ Build > Tools Paths). When an eclipse variable is entered into either the "Build tools folder" or the "Toolchain folder" the OK and Apply buttons are disabled and the message "Value must be an existing directory" is displayed at the top of the dialog.

*: the ability to accept eclipse variables in paths, or a currently non-existent path is provided by the following defaults:
http://gnuarmeclipse.github.io/developer/preferences/ilg.gnuarmeclipse.managedbuild.cross/#defaults

Steps to Reproduce

  1. In a C Executable Project with toolchain set to Cross ARM GCC open project properties > C/C++ Build > Tools Paths
  2. In "Build tools folder" or "Toolchain folder" field enter a path containing an eclipse variable (eg ${eclipse_home}bin) and Click OK.
    Actual: properties dialog is not dismissed. Instead the OK and Apply buttons become greyed out.
    Expected: properties dialog is dismissed and value is set.
  3. Click in the "Build tools folder" or "Toolchain folder" field again.
    Actual: Page message area displays error marker and text "Value must be an existing directory".
    Expected: not error message.

Versions

  • [plug-in version] tag v3.1.1-201606210758, ilg.gnuarmeclipse.managedbuild.cross v2.2.1
  • [Eclipse version] Mars.2
  • [Java version] 1.7
  • [operating system] All

I can supply a patch if you like?

@ilg-ul ilg-ul added the enhancement label Jul 8, 2016

@ilg-ul

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2016

I can supply a patch if you like?

yes, please do.

@ghost

This comment has been minimized.

Copy link
Author

commented Jan 12, 2017

Applying updates from http://gnuarmeclipse.sourceforge.net/updates-test (201701102234) provides fixes for:

  1. Preferences Global Tools Paths and Workspace Tools Paths don't honour strict folder check #126
  2. Project properties Tools Paths does not support eclipse variables #125
  3. Unable to start a debug session after updating to Eclipse Neon.2 (4.6.2) #156
    I've tested with J-Link debug adapter only.

@ilg-ul ilg-ul added this to the v3.2.1 milestone Jan 14, 2017

@ilg-ul

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2017

fixed in v3.2.1-201701141320

@ilg-ul ilg-ul closed this Jan 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.