New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device name of GDB QEMU Debugging configuration does trigger a change that can be saved #170

Closed
oallaire opened this Issue Jan 25, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@oallaire

Description

When editing a QEMU Debug Configuration (Debug Configurations -> GDB QEMU Debugging configuration), changing the Device name field of the Debugger tab does enable the apply button.

In order to save the modified Device name, you have to modify another field (say add and remove a character). You will then see the apply button as enabled.

Steps to Reproduce

  1. Modify the Device name
  2. Try to click apply

Expected behavior:

The expected behavior would be to have the apply button enabled when you modify the Device name field.

Actual behavior:

The apply button stays disabled (grayed out).

Versions

  • GNU ARM C/C++ QEMU Debugging version 3.1.2.201701141320
  • Eclipse Version: Mars.1 Release (4.5.1)
  • Java version 1.8.0_77
  • Windows 10 x64
  • Toolchain version 5.2 2015q4

Thanks!

@ilg-ul ilg-ul self-assigned this Jan 25, 2017

@ilg-ul ilg-ul added the bug label Jan 25, 2017

@oallaire

This comment has been minimized.

Show comment
Hide comment
@oallaire

oallaire Jan 27, 2017

Hi!

I realize now that I could of fixed this bug myself. Do you mind if I take a shot at it and submit a pull request? I'm asking in case you already fixed it.

Hi!

I realize now that I could of fixed this bug myself. Do you mind if I take a shot at it and submit a pull request? I'm asking in case you already fixed it.

@ilg-ul

This comment has been minimized.

Show comment
Hide comment
@ilg-ul

ilg-ul Jan 27, 2017

Contributor

you can take a look, but I know what is wrong, there is a callback missing on that widget.

I planned to fix the problem these days.

Contributor

ilg-ul commented Jan 27, 2017

you can take a look, but I know what is wrong, there is a callback missing on that widget.

I planned to fix the problem these days.

@ilg-ul

This comment has been minimized.

Show comment
Hide comment
@ilg-ul

ilg-ul Jan 27, 2017

Contributor

please try 3.3.1.201701271724 from updates-test

Contributor

ilg-ul commented Jan 27, 2017

please try 3.3.1.201701271724 from updates-test

@ilg-ul ilg-ul added this to the v3.3.1 milestone Jan 27, 2017

@oallaire

This comment has been minimized.

Show comment
Hide comment
@oallaire

oallaire Jan 29, 2017

It works, thanks for the quick fix!

Note that to do the update, I had to follow the instructions here: #171, but it worked after applying these steps.

It works, thanks for the quick fix!

Note that to do the update, I had to follow the instructions here: #171, but it worked after applying these steps.

@ilg-ul

This comment has been minimized.

Show comment
Hide comment
@ilg-ul

ilg-ul Feb 25, 2017

Contributor

fixed since 3.3.1-201702251311

Contributor

ilg-ul commented Feb 25, 2017

fixed since 3.3.1-201702251311

@ilg-ul ilg-ul closed this Feb 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment