Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyOCD target override handling. #329

Merged
merged 1 commit into from Dec 15, 2018

Conversation

Projects
None yet
2 participants
@flit
Copy link
Collaborator

flit commented Dec 15, 2018

This PR resolves the root cause of issue #225. It changes TabDebugger to correctly convert between the target name and target part number. (Currently the part number is almost always just an uppercase version of the name, except for cortex_m/CoreSightTarget.) Also fixes problems with the target name not being saved to and restored from the launch config.

(The original report in the description of #225 about upper-case versus lower-case was actually handled long ago on pyOCD itself. But there was this real underlying issue.)

Closes #225

Fix pyOCD target override handling.
- TabDebugger maintains two maps to convert between target name and
  target part number. (Currently the part number is almost always just
  an uppercase version of the name, except for cortex_m/CoreSightTarget.)
- The target name saved in the configuration is converted to the part
  number for display in the target override combo box. The reverse
  conversion is applied when applying changes to the config.
- Unknown target names are supported by saving/displaying as-is.
- Also made the target name combo box 3x wider.
- This fixes #225.

@ilg-ul ilg-ul merged commit 7b75050 into gnu-mcu-eclipse:develop Dec 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ilg-ul ilg-ul added this to the v4.5.1 milestone Jan 1, 2019

@ilg-ul

This comment has been minimized.

Copy link
Contributor

ilg-ul commented Jan 1, 2019

fixed since v4.5.1-201901011632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.