Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves 498 #510

Merged
merged 2 commits into from Nov 10, 2018
Merged

Solves 498 #510

merged 2 commits into from Nov 10, 2018

Conversation

GillesDuvert
Copy link
Contributor

very ugly as it introduces a parameter in Run(). Better than not having autoprint?

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #510 into master will decrease coverage by <.01%.
The diff coverage is 85.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
- Coverage   43.76%   43.76%   -0.01%     
==========================================
  Files         295      295              
  Lines       95734    95739       +5     
==========================================
- Hits        41901    41900       -1     
- Misses      53833    53839       +6
Impacted Files Coverage Δ
src/prognode.hpp 85.63% <ø> (ø) ⬆️
src/GDLInterpreter.hpp 59.8% <ø> (ø) ⬆️
src/prognodeexpr.cpp 64.28% <0%> (ø) ⬆️
src/dinterpreter.cpp 51.43% <100%> (-0.09%) ⬇️
src/GDLInterpreter.cpp 52.1% <100%> (+0.11%) ⬆️
src/basic_fun.cpp 46.98% <100%> (ø) ⬆️
src/prognode.cpp 73.96% <83.33%> (ø) ⬆️
src/gdl.cpp 39.39% <0%> (-2.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdf001c...68486c2. Read the comment docs.

@alaingdl alaingdl merged commit e35e9a8 into gnudatalanguage:master Nov 10, 2018
@GillesDuvert
Copy link
Contributor Author

Still, as mentioned, .g files should be updated.

@GillesDuvert GillesDuvert deleted the solves_498 branch November 14, 2018 17:12
@opoplawski
Copy link
Contributor

Hmm, I guess it was - why no CI build tests for it?

@GillesDuvert
Copy link
Contributor Author

It's because you recompile from the .g files using "stock" ANTLR.
As I mentioned, .g files should be updated. (easy)
Build checks are not using the .g files.
Such situation is bound to happen again if Travis does not check it.

GillesDuvert added a commit to GillesDuvert/gdl that referenced this pull request May 14, 2019
…anguage#543 things.

Added a more subtle patch at the right place.
Behaviour looks like idl.
GillesDuvert added a commit to GillesDuvert/gdl that referenced this pull request May 15, 2019
…anguage#543 things.

Added a more subtle patch at the right place.
Behaviour looks like idl.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants