Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Various fixes and improvement #9

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
2 participants

ppg commented Oct 13, 2011

Hi,

Not sure if you're interested in maintaining this anymore (I'm switching over to delayed_job as an FYI) but I figured just in case I'd send back a pull request for the modest improvements I made while I was using BackgrounDRB.

Thanks,
\Peter

ppg added some commits Jan 7, 2011

Try to detect a dead worker and restart in backgroundrb.
In master_worker we can detect the error condition that occurs when a worker dies silently and then restart the worker there instead of throwing a nil exception error.
Bug: fix exception logging on persistent tasks, the backtrace was bei…
…ng passed in instead of the whole exception.
Bug: Fix issue with repeated attempts to execute a persistent task ap…
…pearing to cause a 'value too long for database' error.

Within a transaction the job_key is changed to say finished and the time; however if the transaction fails and the item is retried, it will keep appending more and more to the job_key.  The actually intent is to store the original key and always try to set it to finished_{time}_{original_key}.
Update PacketLogger to inherit from and implement the standard Logger…
… class interface so that it can print out time, debug levels, etc.
Improve exception logging messages to include time, have more thoroug…
…h information, and be more consistent between the two definitions of it.

ppg commented Aug 17, 2015

@gnufied Are you interested in this PR? I'm cleaning house and was going to close if there was no more interest.

ppg commented Sep 1, 2017

6 year closing mark

@ppg ppg closed this Sep 1, 2017

Owner

gnufied commented Sep 1, 2017

Lol. sorry I don't maintain this anymore. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment