-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
working on mongolog_purge commands #70
Conversation
Just updating readme with the new changes
#- PYMONGO=">=3.0" DJANGO=">=1.9" | ||
- PYMONGO="==2.4" | ||
- PYMONGO=">=3.0" | ||
- PYMONGO=">=3.0" DJANGO="==1.9.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be inclined to peg this to the next Django LTS release, but since we are pegged to 1.9.8 at HBX I'm having travis run tests against that specific version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, let's that django upgrade here asap
if django_version < 2: | ||
from django.core.urlresolvers import reverse | ||
else: | ||
from django.urls import reverse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool and clean
|
||
def confirm(self, **options): | ||
if not options['force']: | ||
while 1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good
Looks like this PR addresses issue #9 Check minimum version we are compatible with, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Looks great |
No description provided.