Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add keyboard shortcut for hiding all lines in wxt #1

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

jonhoo commented Aug 7, 2013

When plotting many aspects of a dataset in a single graph, it is often convenient to be able to hide all lines and then only selectively enable those that are of interest. This makes 'c' a keyboard shortcut for doing this in wxterminal.

Here, we a case is added to wxtPanel::OnKeyDownChar for handling this. In the long term, a better solution might be to dispatch a command like "hide line 1" to the main gnuplot process, which then triggers a replot, but then there first has to be a way of targeting a command to a specific line.

Patch has been tested against the latest CVS version on Arch Linux x64.

@jonhoo jonhoo Add keyboard shortcut for hiding all lines in wxt
When plotting many aspects of a dataset in a single graph, it is often convenient to be able to hide all lines and then only selectively enable those that are of interest. This makes 'c' a keyboard shortcut for doing this in wxterminal.

Here, we a case is added to wxtPanel::OnKeyDownChar for handling this. In the long term, a better solution might be to dispatch a command like "hide line 1" to the main gnuplot process, which then triggers a replot, but then there first has to be a way of targeting a command to a specific line.

Patch has been tested against the latest CVS version on Arch Linux x64.
7a3ebc6

jonhoo commented Aug 7, 2013

Also submitted in SourceForge as https://sourceforge.net/p/gnuplot/patches/633/

mojca commented Aug 7, 2013

Hi,

I'm not sure if this reply goes to you (I hope it does - please
confirm), but I published an unofficial CVS import into GitHub, so the
developers aren't seing your patch here.

Mojca

On Wed, Aug 7, 2013 at 10:05 PM, Jon Gjengset notifications@github.com wrote:

When plotting many aspects of a dataset in a single graph, it is often
convenient to be able to hide all lines and then only selectively enable
those that are of interest. This makes 'c' a keyboard shortcut for doing
this in wxterminal.

Here, we a case is added to wxtPanel::OnKeyDownChar for handling this. In
the long term, a better solution might be to dispatch a command like "hide
line 1" to the main gnuplot process, which then triggers a replot, but then
there first has to be a way of targeting a command to a specific line.

Patch has been tested against the latest CVS version on Arch Linux x64.


You can merge this Pull Request by running

git pull https://github.com/Jonhoo/gnuplot patch-1

Or view, comment on, or merge it at:

#1

Commit Summary

Add keyboard shortcut for hiding all lines in wxt

File Changes

M src/wxterminal/wxt_gui.cpp (7)

Patch Links:

https://github.com/gnuplot/gnuplot/pull/1.patch
https://github.com/gnuplot/gnuplot/pull/1.diff

jonhoo commented Aug 7, 2013

Ah, so this is not actually an official import then. Fair enough; I've submitted it to the official SourceForge as well anyway. Creating it under a user called "gnuplot" makes it seem like it's an official one... Might want to change that?

@jonhoo jonhoo closed this Aug 10, 2013

@jonhoo jonhoo deleted the unknown repository branch Aug 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment