Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove MPSK receiver #1083

Closed
n-west opened this issue Nov 4, 2016 · 5 comments

Comments

Projects
None yet
5 participants
@n-west
Copy link
Member

commented Nov 4, 2016

Deprecate and remove the C++ MPSK receiver block

  • gr-digital/include/gnuradio/digital/mpsk_receiver_cc.h
  • gr-digital/lib/mpsk_receiver_cc_impl.cc
  • gr-digital/lib/mpsk_receiver_cc_impl.h
  • gr-digital/grc/digital_mpsk_receiver_cc.xml

Rationale

This is a very specific implementation that would be more useful as an example using filter blocks and a constellation mod/demod pair. When deleting ensure that such an example exists.

@n-west n-west added the API Change label Nov 4, 2016

@n-west n-west added this to the Release 3.8 milestone Nov 4, 2016

@n-west n-west added the digital label Nov 4, 2016

@jmcorgan jmcorgan self-assigned this Nov 12, 2016

@jmcorgan

This comment has been minimized.

Copy link
Contributor

commented Nov 12, 2016

Implemented in #1097 for master and #1098 for next.

@jmcorgan

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2016

Merged.

@jmcorgan jmcorgan closed this Nov 15, 2016

@centromere

This comment has been minimized.

Copy link

commented May 8, 2017

When deleting ensure that such an example exists.

Where may I find this example? @jmcorgan @n-west

@intra-au

This comment has been minimized.

Copy link

commented Nov 25, 2017

@n-west @jmcorgan can you please point me to the example using filter blocks and a constellation mod/demod pair (migration path from mpsk_receiver_cc if you will?)

@ecarl65

This comment has been minimized.

Copy link

commented Sep 28, 2018

EDIT: After some searching it looks like there's a "generic" mod/demod example at gr-digital/python/generic_mod_demod.py. I'm not entirely sure if it includes all that I want (eg. the previous code handled pi/4 DQPSK), but I think it likely will with some tweaking of parameters. It appears to have the same types of inputs and outputs as the examples. Sorry for the confusion in the original comment.

Tagging @intra-au and @centromere to show them where the new examples live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.