Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Narrowband examples necessary #1958

Open
marcusmueller opened this issue Aug 17, 2018 · 0 comments
Open

New Narrowband examples necessary #1958

marcusmueller opened this issue Aug 17, 2018 · 0 comments
Labels
digital examples Regression soft-milestone Features that need to happen around said milestone, but not immediately at the same point in time
Projects
Release 3.9 Release 3.10
Milestone
Release 3.9

Comments

@marcusmueller
Copy link
Member

marcusmueller commented Aug 17, 2018 •
edited

Removal of message_sink / _souce broke nearly all narrowband examples.

a) we should have unit tests for examples

b) we need new examples.

The current nonfunctional examples bear no educational value and can / will be removed (#1959)
@marcusmueller marcusmueller added this to the Release 3.8 milestone Aug 17, 2018
marcusmueller added a commit to marcusmueller/gnuradio that referenced this issue Aug 17, 2018
@marcusmueller
Remove all examples depending on and references to message_s{ource,ink}
2105a0b 
Fixes gnuradio#1024.

Note that this only removes non-functional code which should have been
removed when message_s{ink,ource} were removed.

This also means that we'll need new narrowband examples (gnuradio#1958).
@marcusmueller marcusmueller mentioned this issue Aug 17, 2018
Merged
@marcusmueller marcusmueller added the soft-milestone Features that need to happen around said milestone, but not immediately at the same point in time label Aug 18, 2018
marcusmueller added a commit to marcusmueller/gnuradio that referenced this issue Aug 26, 2018
@marcusmueller
Remove all examples depending on and references to message_s{ource,ink}
060e8f7 
Fixes gnuradio#1024.

Note that this only removes non-functional code which should have been
removed when message_s{ink,ource} were removed.

This also means that we'll need new narrowband examples (gnuradio#1958).
marcusmueller added a commit that referenced this issue Aug 27, 2018
@marcusmueller
Remove all examples depending on and references to message_s{ource,ink}
e40ce6d 
Fixes #1024.

Note that this only removes non-functional code which should have been
removed when message_s{ink,ource} were removed.

This also means that we'll need new narrowband examples (#1958).
marcusmueller added a commit to marcusmueller/gnuradio that referenced this issue Aug 29, 2018
@marcusmueller
Remove all examples depending on and references to message_s{ource,ink}
cfcbc0f 
Fixes gnuradio#1024.

Note that this only removes non-functional code which should have been
removed when message_s{ink,ource} were removed.

This also means that we'll need new narrowband examples (gnuradio#1958).
@marcusmueller marcusmueller mentioned this issue Aug 29, 2018
Merged
@devnulling devnulling added this to To do in Release 3.9 via automation Jan 21, 2020
@devnulling devnulling modified the milestones: Release 3.8+, Release 3.9 Jan 21, 2020
@mormj mormj added this to To do in Release 3.10 via automation Feb 26, 2021
@mormj mormj moved this from To do to Punted in Release 3.10 Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
digital examples Regression soft-milestone Features that need to happen around said milestone, but not immediately at the same point in time
Projects
Release 3.10
Punted
Release 3.9
  
To do
Milestone
Release 3.9
Development

No branches or pull requests
2 participants
@marcusmueller @devnulling