Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpsk_stage6.grc example flowgraph output wrong #3599

Closed
guokr321 opened this issue Jun 23, 2020 · 11 comments · Fixed by #3630
Closed

mpsk_stage6.grc example flowgraph output wrong #3599

guokr321 opened this issue Jun 23, 2020 · 11 comments · Fixed by #3630

Comments

@guokr321
Copy link

Hello,
I run the mpsk_stage6.grc example flowgraph of https://wiki.gnuradio.org/index.php/Guided_Tutorial_PSK_Demodulation, using gnuradio v3.7.13.5 and master version respectively, the output bit stream and original bit stream have been witten into Filesink, but they are different. How to get them synchronized?

@guokr321
Copy link
Author

Further more, using QPSK, input 1000 0x0000, 0xFFFF, 0x5555, and 0xAAAA into the Constellation Modulator, the output bit stream is the same as the input bit stream, but input random hex, the output bit stream is different from the input bit stream, and none pattern can't be found.

@duggabe
Copy link
Contributor

duggabe commented Jun 28, 2020

@guokr321
Copy link
Author

both. the new mpsk_stage6.grc example flowgraph is run under master version. the old mpsk_stage6.grc example flowgraph is run under v3.7.13.5. the result is same.

@duggabe
Copy link
Contributor

duggabe commented Jul 5, 2020

I have found, corrected, and tested the problems with mpsk_stage6.grc
The order of blocks should be Constellation_Decoder, Differential_Decoder, and Map.
The receive Map should be [0,1,2,3].
A corrected flowgraph is in https://pastebin.com/2mRCzmPF
(The delay is 58.)
I tested with Ubuntu 18.04 and GRC 3.8.1.0; also Ubuntu 20.04 and GRC 3.9.0.0-git

I will write a PR once you have tested it.

@guokr321
Copy link
Author

guokr321 commented Jul 6, 2020

I have found, corrected, and tested the problems with mpsk_stage6.grc
The order of blocks should be Constellation_Decoder, Differential_Decoder, and Map.
The receive Map should be [0,1,2,3].
A corrected flowgraph is in https://pastebin.com/2mRCzmPF
(The delay is 58.)
I tested with Ubuntu 18.04 and GRC 3.8.1.0; also Ubuntu 20.04 and GRC 3.9.0.0-git

I will write a PR once you have tested it.

I save the link as mpsk7.grc, and
Loading: "/home/frontier/work/rcs2test/mpsk7.grc"
Error: while scanning for the next token
found character '\t' that cannot start any token
in "/home/frontier/work/rcs2test/mpsk7.grc", line 2, column 1

Failure

@duggabe
Copy link
Contributor

duggabe commented Jul 6, 2020

Once you go to the pastebin link, you need to click on the 'raw' icon to get the unformatted text. Alternately, you can click on the 'download' icon.

@guokr321
Copy link
Author

guokr321 commented Jul 7, 2020

In the GRC 3.7.13.5, I modified mpsk_stage6.grc according your suggestion, and tested OK.

@guokr321
Copy link
Author

guokr321 commented Jul 8, 2020

By the way, how to support 8PSK and 256QAM?

@duggabe
Copy link
Contributor

duggabe commented Jul 9, 2020

By the way, how to support 8PSK and 256QAM?

That would be material for another tutorial...

@andremartins4
Copy link

The file is no longer available, is there a way to find? Thank you

@duggabe
Copy link
Contributor

duggabe commented Jan 6, 2021

The pastebin file mentioned above was a temporary measure until the revised file was merged into github.
The tutorial https://wiki.gnuradio.org/index.php/Guided_Tutorial_PSK_Demodulation#Decoding section has the correct link to the file:
https://raw.githubusercontent.com/gnuradio/gnuradio/master/gr-digital/examples/mpsk_stage6.grc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants