grc: snippets before init is called #6446
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are situations where snippets need to be inserted before block initialization, such as when
a block constructor makes contact with an external server, it might be handy to initialize the server
or check whether it is ready prior to calling the flowgraph init function that calls the block constructor
The problem with the current construct is snippets can only be injected after the flowgraph is initialized,
since they use
self
as a reference to the flowgraph object. There is probably a better way to do thisbut the easy solution is to pass
None
as what will become self, and snippets that are inserted beforemain are not able to make calls to
self
Notes:
I'm wondering if it would be more useful to have the injection point inside the
top_block.__init__
after variablesare instantiated, then the snippet would have access to variables
Related Issue
None
Which blocks/areas does this affect?
Just GRC when snippets are used
Testing Done
Checklist