New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort input files #1322

Merged
merged 1 commit into from Jun 23, 2017

Conversation

Projects
None yet
2 participants
@bmwiedemann
Contributor

bmwiedemann commented Jun 5, 2017

when building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output,
thus without the patch, builds (in disposable VMs) would usually differ.

See https://reproducible-builds.org/ for why this matters.

such diffs affected volk-config-info volk_profile volk.h volk_typedefs.h gnuradio/xml/index.xml gnuradio/html/volk_8h_source.html etc
http://rb.zq1.de/compare.factory-20170531/gnuradio-compare.out

sort input files
when building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output,
thus without the patch, builds (in disposable VMs) would usually differ.

See https://reproducible-builds.org/ for why this matters.

@jmcorgan jmcorgan added the Bug Fix label Jun 7, 2017

@jmcorgan jmcorgan modified the milestones: Release 3.7.11.1, Release 3.7.12 Jun 7, 2017

@jmcorgan jmcorgan merged commit 3d85897 into gnuradio:master Jun 23, 2017

5 checks passed

bb/Ubuntu_14_04_64_py2_qt4_master Build done.
Details
bb/Ubuntu_14_04_64_py2_qt4_next Build done.
Details
bb/Ubuntu_16_04_64_py2_qt4_master Build done.
Details
bb/Ubuntu_16_04_64_py2_qt5_next Build done.
Details
bb/pull_request_runner Build done.
Details
@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Jun 25, 2017

Contributor

note: this one is related: gnuradio/volk#116

Contributor

bmwiedemann commented Jun 25, 2017

note: this one is related: gnuradio/volk#116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment