New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModTool: Fix linting in the python templates #1845

Closed
wants to merge 1 commit into
base: next
from

Conversation

Projects
None yet
2 participants
@swap-nil7
Copy link
Contributor

swap-nil7 commented Jun 25, 2018

I have fixed some of the lint issues in python templates.

@mbr0wn

mbr0wn approved these changes Jun 25, 2018

@@ -55,96 +57,95 @@

name_dict = {}

def log_output_name (name):
(base, ext) = os.path.splitext (name)
def log_output_name(name):

This comment has been minimized.

@mbr0wn

mbr0wn Jun 25, 2018

Member

I guess your linter would also complain about the lack of a docstring?

This comment has been minimized.

@swap-nil7

swap-nil7 Jun 25, 2018

Contributor

Yes, there are a lot of functions with missing docstring. Almost all the functions in build_utils_codes.py.

@swap-nil7 swap-nil7 force-pushed the swap-nil7:lint_fixes branch from 4c730c8 to 6990fd2 Jun 28, 2018

@swap-nil7 swap-nil7 changed the base branch from python3 to next Jun 28, 2018

@swap-nil7

This comment has been minimized.

Copy link
Contributor

swap-nil7 commented Jul 18, 2018

Closing the PR since the work is already there in #1873.

@swap-nil7 swap-nil7 closed this Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment