New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModTool: Relative imports in python templates #1857

Closed
wants to merge 1 commit into
base: next
from

Conversation

Projects
None yet
2 participants
@swap-nil7
Copy link
Contributor

swap-nil7 commented Jun 29, 2018

In my opinion, imports should be relative in python scripts.

@noc0lour
Copy link
Member

noc0lour left a comment

Are these the only places left to fix the relative imports? If yes, this is good to go. If not we might consider pulling in more relative import fixes in here.

@@ -2,7 +2,7 @@

#define HOWTO_API

%include "gnuradio.i" // the common stuff
%include "gnuradio.i" // the common stuff

This comment has been minimized.

@noc0lour

noc0lour Jun 29, 2018

Member

Was this accidental?

This comment has been minimized.

@swap-nil7

swap-nil7 Jun 29, 2018

Contributor

No, I have replaced tab spaces which look not so good using vim.

@swap-nil7 swap-nil7 force-pushed the swap-nil7:relative branch from 75be4c9 to ec6d1d3 Jun 29, 2018

@swap-nil7

This comment has been minimized.

Copy link
Contributor

swap-nil7 commented Jul 18, 2018

Closing the PR since the work is already there in #1873.

@swap-nil7 swap-nil7 closed this Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment