modtool: Switched over to mako template engine #303
Conversation
|
Not sure if this was a just a trial, but it adds a dependency on python-mako (and its dependencies). We'll need to have cmake machinery to test for this, and evaluate the availability of the package across all the platforms/versions we support. |
|
Needs rebase. |
|
Rebased. |
|
Would it make sense to merge this into 'next' now? |
|
Should pull in @skoslowski and probably @trondeau: As soon as we merge, we add mako as a dependency. In previous discussions, we already discussed having both Cheetah and Mako as deps, so that would be OK. It would mean another commit to update the docs and the CMake, and I would volunteer to do those, too. However, we still need to move Cheetah out of GRC and I'm not sure what the plans are on that. If it's not going to happen for 3.8, that would be reason not to merge this. Otherwise, we're good. |
|
It will be essential to pull out Cheetah from GRC for 3.8; we won't have time to do it otherwise for a very long time, and we're facing Python 3 issues in six months or so. |
|
OK, in that case, merge it, and I'll add another PR today for Mako. |
|
I agree with @jmcorgan; we'll need Mako support in GRC for 3.8. |
|
@mbr0wn Can you just add the new commits on top of this PR? |
|
Will do! |
|
Updated. |
|
Note I didn't remove Cheetah or even touch anything GRC-related. |
python-mako will be included as a dependency in GNU Radio 3.8 (see gnuradio/gnuradio#303). Changes following gnuradio/volk#94
No description provided.